Skip to content

Updated Valid constraint reference #4351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Updated Valid constraint reference #4351

wants to merge 1 commit into from

Conversation

inso
Copy link

@inso inso commented Oct 20, 2014

Q A
Doc fix? yes
New docs? no
Applies to 2.5
Fixed tickets

wouterj
wouterj reviewed Oct 26, 2014
View reviewed changes
reference/constraints/Valid.rst
@@ -1,6 +1,10 @@
Valid
=====

.. caution::

The ``deep`` option is deprecated since Symfony 2.5 and will be removed in Symfony 3.0.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be moved to just after the deep title.

@wouterj
Copy link
Member

wouterj commented Oct 26, 2014

Thank you! You fixed 2 important things here :) However, they should not all be merged into the same version:

  • The option exists since 2.1, so the description of the option should be merged into the 2.3 branch (2.1 and 2.2 are no longer maintained). The same applies to the removal of the message option.
  • The option was deprecated since 2.5 and the default also changed from false to true in 2.5. These changes should be merged into the 2.5 branch.

Could you please break it up into 2 seperate PRs? First you need to create a PR against the 2.3 branch with the removal of message and the description of deep. After that one is merged, you should create a PR about the deprecation and default value change in the 2.5 branch.

If you don't know how to do this or you don't have time, don't hesitate to say that. I'll take it over/help you. Thanks again!

inso pushed a commit to inso/symfony-docs that referenced this pull request Oct 27, 2014
Updated Valid constraint reference
a50bb96 
Revised PR symfony#4351 for 2.3 branch
@inso inso mentioned this pull request Oct 27, 2014
Merged
@inso inso closed this Oct 27, 2014
weaverryan added a commit that referenced this pull request Oct 29, 2014
@weaverryan
bug #4381 Updated Valid constraint reference (inso)
68a2c7b 
This PR was merged into the 2.3 branch.

Discussion
----------

Updated Valid constraint reference

| Q              | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3
| Fixed tickets |

Revised PR #4351 for 2.3 branch

Commits
-------

a50bb96 Updated Valid constraint reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inso @wouterj